Comments on: Disappearing Custom Post Data

By: Michael

Michael — Fri, 06 Aug 2010 11:51:31 +0000

The possible downside depends on where you’re calling save_salary. If you’re hooking the save_post event then you risk the problem I mentioned when a post is edited using the Quick Editor, or even when a comment is made on the post. At the very least you should test that you actually have the salary field – if (isset($_POST["salary"])) ... .

Also, if you’re expecting that “salary” is a pure number, you should typecast it so that any errors will be spotted when the post is saved, not when the value is being used, ie (float) $_POST["salary"].

By: Craig Hooghiem

Craig Hooghiem — Thu, 05 Aug 2010 17:36:33 +0000

Is there a reason I might not be experiencing this?
I’m using the latest version of WP and the only function I use for saving is:

function save_salary(){
global $post;
update_post_meta($post->ID, “salary”, $_POST["salary"]);
}

Is there a downside to what I’m doing?

By: lizuka

lizuka — Mon, 05 Jul 2010 09:26:10 +0000

is there ? Plugin development is new to me, and I’m eager to learn all the tricks to make decent code.
Also the API could be better documented sometimes.

By: Michael

Michael — Fri, 02 Jul 2010 09:26:20 +0000

Yeah, that’s really a throw-back to earlier versions of WP. I haven’t seen any places in WP in recent versions where $post_id isn’t set when the action is called.

I should also say there is a new “standard” way of testing for revisions and getting the original “real” post ID, however you still need to check that your plug-in fields are present in $_POST[] because they won’t be when the quick editor is used instead of the full post editor screen.

By: lizuka

lizuka — Fri, 02 Jul 2010 09:16:48 +0000

Thanks for this tip which has helped me a lot
However I’ve deleted all together the 2nd line of your code :
if (!$post_id) $post_id = $_POST['post_ID'];
because it didn’t seem to be of any use.